(WIP) Django-parler translations #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juyrjola
reviewed
Jul 24, 2017
| case = models.ForeignKey(Case, related_name='actions', help_text=_('Case this action is related to'), blank=True, | ||
| null=True) | ||
| ordering = models.IntegerField(help_text=_('Ordering of this action within a meeting')) | ||
| article_number = models.CharField(max_length=255, blank=True, | ||
| help_text=_('The article number given to this action after decision')) | ||
| resolution = models.CharField(max_length=255, blank=True, |
There was a problem hiding this comment.
There are only a fixed number of different possible resolutions, so resolution should either be a non-translated CharField or a ForeignKey.
juyrjola
reviewed
Jul 24, 2017
| 'but start from a minimal set)')) | ||
| translations = TranslatedFields( | ||
| title=models.CharField(max_length=255, help_text=_('Title of this content'), blank=True), | ||
| type=models.CharField(max_length=255, help_text=_( |
juyrjola
reviewed
Jul 24, 2017
| @@ -70,13 +74,15 @@ def __str__(self): | |||
|
|
|||
| class Content(DataModel): | |||
There was a problem hiding this comment.
Actually, I think it might be better to make Content fully translated, so skip translating the fields here for now. In the future, we could add a language_code field.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.