POS-1253 Allow Canadian routing numbers

[citybasecnocon]

Description

The impetus for this set of changes to the Redux Freeform library are meant to allow Canadian routing numbers in the Manual Entry form used in POS Frontend. While we want to allow Canadian numbers for recording purposes, we do not need to make sure the Canadian numbers are all real routing numbers because Canadian checks cannot be processed as ACH transactions anyway. According to Greg Weppler,

The routing number is definitely used for payments, like for submitting an ACH payment, but Canadian checks can't be processed as an ACH. Canadian checking (Canadian routing numbers) will only ever be reported, and will fail if added to an ACH file.

So it doesn't matter if the Canadian routing numbers are for real banks because we can't process those as ACH transactions even if they were real numbers. Therefore, I've added a new validator that preserves the pre-existing checksum validation for U.S. routing numbers and adds functionality that allows Canadian numbers to be entered and recorded, but not used in any real transactions.

This new validator, isAmericanOrCanadianRoutingNumber can be applied to any routing number input field that wants to allow the entry of Canadian routing numbers without disrupting the validation for U.S. numbers.

View in preview environment.

Risk Assessment

None. This is an update to a library that will not impact anything until its installed in POS Frontend. See https://github.com/CityBaseInc/pos-frontend/pull/526.

Changes

• Add content to validation API README for isAmericanOrCanadianRoutingNumber validator.
• Add tests for isAmericanOrCanadianRoutingNumber validator
• Add new isAmericanOrCanadianRoutingNumber validator to allow Canadian values

Code of Conduct

https://github.com/CityBaseInc/redux-freeform/blob/master/CODE_OF_CONDUCT.md

Concerns

(Optional)

Screenshots

9-Digit Routing Number Checksum is Valid

9-Digit Routing Number Checksum is Invalid

Routing Number Length is Too Short

An 8-digit number is valid

Routing Number Length is Too Long

[jpena-cb]

I believe using checksum is important for detecting fraud. Is there a way to handle this in a country-specific way?

[citybasecnocon]

I believe using checksum is important for detecting fraud. Is there a way to handle this in a country-specific way?

@jpena-cb You're correct. The reason I have to remove it is because Canadian routing numbers are sometimes 9 digits instead of 8, so there's not a reliable way to tell which type of number you're dealing with before applying validations.

[citybasecnocon]

@jpena-cb Could you take another look at this PR when you get a chance?

[jpena-cb]

Looks good!

[mattr-cb]

I added this, it matches the dockerfile

[mattr-cb]

Tests needed to be updated to match these changes 2559d6b#diff-56017878dbd7a7cfc83c47102fb03e5116813578d085592361f7247fbc0e70a5R566