Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Bump @actions/github from 2.2.0 to 5.1.1" #33

Merged

Conversation

jaylenw
Copy link
Member

@jaylenw jaylenw commented Feb 13, 2024

What does this PR do?

Reverts #32

Background info

The bump in the @actions/github package causes tests to fail upon npm install and npm test. I forgot that the installed packages have to be committed to the repository therefore tests were passing that were shown in #32 with packages without 5.1.1 version of @actions/github installed.

 FAIL  test/action.test.js
  ● Test suite failed to run

    TypeError: github.GitHub is not a constructor

      25 |   : config.get('GH_REPOSITORY').split('/', 2);
      26 |
    > 27 | const octokit = new github.GitHub(
         |                 ^
      28 |   core.getInput('github_token', { required: true })
      29 | )
      30 |

      at Object.<anonymous> (action.js:27:17)
      at Object.<anonymous> (test/action.test.js:1:36)

----------|---------|----------|---------|---------|-------------------
File      | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s 
----------|---------|----------|---------|---------|-------------------
All files |       0 |        0 |       0 |       0 |                   
----------|---------|----------|---------|---------|-------------------
Test Suites: 1 failed, 1 total
Tests:       0 total
Snapshots:   0 total
Time:        0.347 s

@jaylenw jaylenw self-assigned this Feb 13, 2024
@jaylenw jaylenw requested a review from a team as a code owner February 13, 2024 01:05
Copy link

codecov bot commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cbd9515) 82.64% compared to head (577de0f) 82.64%.

Additional details and impacted files
@@             Coverage Diff              @@
##           development      #33   +/-   ##
============================================
  Coverage        82.64%   82.64%           
============================================
  Files                1        1           
  Lines              121      121           
  Branches            15       15           
============================================
  Hits               100      100           
  Misses              20       20           
  Partials             1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jaylenw jaylenw merged commit befdd28 into development Feb 13, 2024
8 checks passed
@ita-devops-release-manager ita-devops-release-manager bot added the staged PRs that have been merged into the development branch containing changes yet to be pushed to prod label Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
staged PRs that have been merged into the development branch containing changes yet to be pushed to prod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants