Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wallet: fix custom scrypt parameter usage #279

Merged
merged 1 commit into from
Sep 19, 2023
Merged

wallet: fix custom scrypt parameter usage #279

merged 1 commit into from
Sep 19, 2023

Conversation

ixje
Copy link
Member

@ixje ixje commented Sep 19, 2023

  1. scrypt parameters for the Account instance were not taken into account when calling sign(). Therefore it would always assume the default scrypt parameter. This caused failures in some unittests that used custom scrypt params
  2. when importing a multi-signature account the wallet will try to augment that account with the key material of the related accounts so it can be used for signing. This augmentation did not copy the scrypt parameters which could lead to the same issue as 1.

@coveralls
Copy link

Coverage Status

coverage: 80.751% (-0.03%) from 80.779% when pulling 98f140c on fix-scrypt-params into f607693 on master.

@ixje ixje merged commit fe029d7 into master Sep 19, 2023
@ixje ixje deleted the fix-scrypt-params branch September 19, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants