Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problems
The NEO Virtual Machine has a
Map
type which translates to adict
on the Python side. The keys are restricted to what they callPrimitiveType
s beingBoolean
,Integer
andByteString
stack item types (respectivelybool
,int
andstr
in Python).However, it is also possible to push
bytes
using thePUSHDATA
opcodes which will be converted to aByteString
stack item type. Therefore we can no longer assume that when the VM returns aByteString
stack item that it is always astr
.int
key types would incorrectly be converted tostr
.The solution
This PR removes the "ByteString ==
str
" assumption and also removes theint -> str
conversion.