Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

urls.ts now references *Server.json for return URL. #610

Closed
wants to merge 2 commits into from

Conversation

kjlevitz
Copy link

Reference #596

urls.ts now references *Server.json for return URL.

Note: testServers.json was created with the static test URLs before they were removed.

@snowypowers
Copy link
Member

Whats the purpose of putting this here in helpers? The current usage of urls.ts is for integration testing (and even that is diminished with the usage of a local docker environment). The issue you point to seems to belong in neon-api rather than being a mere helper.

@ixje
Copy link
Member

ixje commented Oct 21, 2020

Kevin, a couple of remarks

  • We discussed that the purpose was to scrape the data from the json files at https://github.com/CityOfZion/neo-mon because the lists there can get updated. This includes it as static data, which is not the same.
  • We also agreed to re-use the existing sorting algorithm and that the getUrl() could accept our dynamic list instead of being limited to the hardcoded MainNet/TestNet lists, I don't see this back in your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants