-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CU-86drpnxv7 - Create a CONTRIBUTING.md file #108
base: main
Are you sure you want to change the base?
Conversation
Task linked: CU-86drpnxv7 Create a CONTRIBUTING.md file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is very very good, better than I expected :D
it just need a few fixes
``` | ||
2. **Run the Rush Change Command:** | ||
|
||
Use the following command, providing a descriptive message of your alterations, and select the appropriate type of modification: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's important to say that if there isn't changes relevant for the users there is no need to add a change message.
|
||
## GitHub Actions Workflows | ||
|
||
- The [``Check Build and Test``](./.github/workflows/check-build-and-test.yml) workflow runs on every pull request to main branch. This workflow checks if a message was added a message on the change log, checks packages are building, and runs E2E tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this text is strange
- [PNPM](https://pnpm.io/) as the package manager | ||
- [ESLint](https://eslint.org/) as the linter | ||
- [Prettier](https://prettier.io/) as the code formatter | ||
- [Prettier](https://prettier.io/) as the code formatter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
repeated
|
||
### Cleaning Rush Js Cash | ||
```bash | ||
rush purge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you explain why this is necessary?
No description provided.