CU-86dt279a1- Fix WalletConnectSdk Examples Build #110
Conversation
|
Task linked: CU-86dt279a1 Fix WalletConnectSdk Examples Build |
1 similar comment
|
Task linked: CU-86dt279a1 Fix WalletConnectSdk Examples Build |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -1,5 +1,9 @@ | |||
| lockfileVersion: '6.0' | |||
|
|
|||
| settings: | |||
| autoInstallPeers: true | |||
There was a problem hiding this comment.
Consider setting excludeLinksFromLockfile to true if you want to reduce the size of the lockfile and make it more readable. However, be aware that this might increase the installation time.
| @@ -48,6 +55,13 @@ packages: | |||
| regenerator-runtime: 0.14.0 | |||
| dev: false | |||
|
|
|||
| /@cspotcode/[email protected]: | |||
| resolution: {integrity: sha512-IchNf6dN4tHoMFIn/7OE8LWZ19Y6q/67Bmf6vnGREv8RSbBVb9LPJxEcnwrcwX6ixSvaiGoomAUvu4YSxXrVgw==} | |||
| engines: {node: '>=12'} | |||
There was a problem hiding this comment.
Please ensure that the node engine version is compatible with the project's node version. If the project's node version is less than 12, this could cause compatibility issues.
| resolution: {integrity: sha512-IchNf6dN4tHoMFIn/7OE8LWZ19Y6q/67Bmf6vnGREv8RSbBVb9LPJxEcnwrcwX6ixSvaiGoomAUvu4YSxXrVgw==} | ||
| engines: {node: '>=12'} | ||
| dependencies: | ||
| '@jridgewell/trace-mapping': 0.3.9 |
There was a problem hiding this comment.
Please specify the version of the @jridgewell/trace-mapping dependency to ensure consistent builds.
| @@ -1046,6 +1114,37 @@ packages: | |||
| typescript: 5.2.2 | |||
| dev: true | |||
|
|
|||
| /[email protected](@types/[email protected])([email protected]): | |||
| resolution: {integrity: sha512-NtVysVPkxxrwFGUUxGYhfux8k78pQB3JqYBXlLRZgdGUqTO5wU/UyHop5p70iEbGhB7q5KmiZiU0Y3KlJrScEw==} | |||
There was a problem hiding this comment.
Please ensure that the integrity of the ts-node package is correct. It is crucial to verify the integrity of the package to ensure that the package has not been tampered with.
| resolution: {integrity: sha512-NtVysVPkxxrwFGUUxGYhfux8k78pQB3JqYBXlLRZgdGUqTO5wU/UyHop5p70iEbGhB7q5KmiZiU0Y3KlJrScEw==} | ||
| hasBin: true | ||
| peerDependencies: | ||
| '@swc/core': '>=1.2.50' |
There was a problem hiding this comment.
Please ensure that the versions of the peer dependencies @swc/core and @swc/wasm are compatible with the rest of the project. Incompatibility can lead to unexpected behavior or crashes.
| '@swc/wasm': | ||
| optional: true | ||
| dependencies: | ||
| '@cspotcode/source-map-support': 0.8.1 |
There was a problem hiding this comment.
Please ensure that the versions of the dependencies are compatible with the rest of the project. Incompatibility can lead to unexpected behavior or crashes.
| '@swc/core': | ||
| optional: true | ||
| '@swc/wasm': | ||
| optional: true |
There was a problem hiding this comment.
Removing the settings section might cause unexpected behavior as it contains important configurations like autoInstallPeers and excludeLinksFromLockfile. Please ensure that these configurations are handled elsewhere in your code or they are no longer needed.
e2e/src/helpers/CommandsHelper.ts
Outdated
| const examplesPath = path.posix.normalize(EXAMPLES_PATH) | ||
|
|
||
| function getAllExamples(): string[] { | ||
| console.log(process.cwd()) |
There was a problem hiding this comment.
Avoid using console.log for debugging purposes. It's better to use a proper debugging tool.
LeonardoDizConde
force-pushed
the
CU-86dt279a1
branch
from
579638d to
337b343
Compare
| @@ -1,5 +1,9 @@ | |||
| lockfileVersion: '6.0' | |||
|
|
|||
| settings: | |||
| autoInstallPeers: true | |||
There was a problem hiding this comment.
Consider adding a brief explanation about the autoInstallPeers and excludeLinksFromLockfile settings. It will help other developers understand why these settings are necessary for this project.
| @@ -30,6 +34,9 @@ devDependencies: | |||
| prettier: | |||
| specifier: ^3.0.3 | |||
| version: 3.0.3 | |||
| ts-node: | |||
| specifier: 10.9.1 | |||
| version: 10.9.1(@types/[email protected])([email protected]) | |||
There was a problem hiding this comment.
The version format for ts-node seems incorrect. It should only contain the version number, not dependencies. Please correct it.
| @@ -48,6 +55,13 @@ packages: | |||
| regenerator-runtime: 0.14.0 | |||
| dev: false | |||
|
|
|||
| /@cspotcode/[email protected]: | |||
| resolution: {integrity: sha512-IchNf6dN4tHoMFIn/7OE8LWZ19Y6q/67Bmf6vnGREv8RSbBVb9LPJxEcnwrcwX6ixSvaiGoomAUvu4YSxXrVgw==} | |||
| engines: {node: '>=12'} | |||
There was a problem hiding this comment.
Please ensure that the node engine version is consistent across all packages. Here, it is specified as '>=12' whereas in line 67, it is specified as '^12.22.0 || ^14.17.0 || >=16.0.0'. This could potentially lead to compatibility issues.
| '@swc/core': | ||
| optional: true | ||
| '@swc/wasm': | ||
| optional: true |
There was a problem hiding this comment.
The removal of the settings block may cause issues if the default settings are not the same as the ones specified here. Please ensure that the removal of these settings does not affect the functionality of the project.
No description provided.