CU-86dtn7n3d - Upgrade @walletconnect/signclient lib to the latest ve… #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| resolution: {integrity: sha512-LPuwb2P+NrQw3XhxGc36+XSvuBPopovXYTR9Ew++Du9Yb/bx5AzBfrIsBoj0EZUifjQU+sHL21sseZ3jerWO/A==} | ||
| /[email protected]: | ||
| resolution: {integrity: sha512-ahC5W1xgou+KTXix4sAO8Ki12Q+jf4i0+tmk3sC+zgcynshkHxzpXdImBehiUYKKKDwvfFiJl1tZt6ewscS1Mg==} | ||
| engines: {node: '>= 0.4'} |
There was a problem hiding this comment.
The engines node version was updated from '>=0.10.0' to '>= 0.4'. This seems like a downgrade rather than an upgrade. Please ensure that this change is intentional and compatible with other dependencies.
| @@ -10655,17 +10863,17 @@ | |||
| resolution: {integrity: sha512-S5wqyz0DXnNJPd/xfIzZ5Xnp1HrJWBczg8mMfMpN78OJ5eDxXyf+Ygld9wX1DnUWbIbhM1YDY95NjR4CBXkb2g==} | |||
| engines: {node: '>= 10.14.2'} | |||
| dependencies: | |||
| '@types/node': 20.10.0 | |||
| '@types/node': 20.12.12 | |||
There was a problem hiding this comment.
Ensure that the updated version @types/node: 20.12.12 is compatible with all other dependencies and the current node version used in the project to avoid potential conflicts or runtime issues.
| @@ -13959,13 +14205,15 @@ | |||
|
|
|||
| /[email protected]: | |||
| resolution: {integrity: sha512-uWjbaKIK3T1OSVptzX7Nl6PvQ3qAGtKEtVRjRuazjfL3Bx5eI409VZSqgND+4UNnmzLVdPj9FqFJNPqBZFve4w==} | |||
| deprecated: Rimraf versions prior to v4 are no longer supported | |||
There was a problem hiding this comment.
The addition of the deprecated field for [email protected] should be accompanied by a plan or task to upgrade or replace this deprecated dependency to avoid potential future issues with unsupported software.
melanke
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rsion