Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CU-86a0vq1ak - Fully implement WcSdk e2e tests (finish the connection and use every command ... #93

Merged
merged 2 commits into from
Oct 16, 2023

Conversation

LeonardoDizConde
Copy link
Contributor

expecing the responses)

@melanke
Copy link
Contributor

melanke commented Oct 6, 2023

1 similar comment
@melanke
Copy link
Contributor

melanke commented Oct 6, 2023

@LeonardoDizConde LeonardoDizConde force-pushed the CU-86a0vq1ak branch 4 times, most recently from dbb08cf to 15fab05 Compare October 9, 2023 17:35
Copy link
Contributor

@melanke melanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You didn't finish your task

examples/wc-dapp-react/src/components/HelloWorld.tsx Outdated Show resolved Hide resolved
e2e/tests/Dapp.spec.ts Outdated Show resolved Hide resolved
expect(newPage).toBeDefined()

// Verify if the URL of the new tab starts with the expected connection URL
expect(newPage.url().startsWith('https://neon.coz.io/connect?uri=')).toBeTruthy()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

again, we don't need to test this.

… and use every command expecing the responses)
@melanke melanke merged commit 3b90db1 into main Oct 16, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants