CU-86a166rph - Implement a new WcSdk (dapp) package for Svelte #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
endkeyCoder
force-pushed
the
CU-86a166rph
branch
from
8344af8 to
82665b8
Compare
melanke
suggested changes
Oct 26, 2023
| /** | ||
| * returns if the session is connected | ||
| */ | ||
| readonly isConnected: Readable<boolean> |
There was a problem hiding this comment.
It will be too difficult to maintain the documentation if one of the libraries has a different usage than the others. Today we have a single "usage" documentation, and both "core" and "react" libraries respect it.
So, instead of isConnected being a getter it need to be a method. The devs will still be able to use session variable to check if they are connected instead of using the method.
Reference: https://github.com/CityOfZion/wallet-connect-sdk/blob/main/USAGE_GUIDE.md#check-if-the-user-is-connected
melanke
suggested changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.