Add fake server & basic tests against it #45
Conversation
|
This is really cool! Thank you for your efforts @ezheidtmann. Regarding your points of clarification: #15 was more of a "cry for help" from me, as I have very little (read: none) experience with writing tests for Python projects. Tagging @hunterowens @ian-r-rose who may be able to weigh in with their thoughts. I am open to whatever best-practices or standard approaches there are to the questions above. |
|
Great. I've usually added tests either to an existing project or within Django, with has an opinionated approach and a custom test runner, so I'm not an expert on the Python community customs here. |
|
Tagging @johnclary as well, since he seems to have a ton of Python experience (yes, I stalked your profile John!) |
* Convert shapely to geojson dict * minor import cleanups * removing geopandas install_requires
option to read from local registry file
A little refactoring to allow consumers to iterate pages from each provider. Intention is to maintain ProviderClient behavior except for these changes: - don't request a second page if the first page is empty (previously would have made a second request if `next_url` was present on first page) - don't return any results for a provider if any pages failed (previously would have returned partial results if a page other than the first failed)
Perhaps an improvement to names, re: CityofSantaMonica#46 CityofSantaMonica#35
ezheidtmann
force-pushed
the
add-tests
branch
from
37a1661 to
84f3f9a
Compare
|
Rebased on #46 and |
ezheidtmann
force-pushed
the
add-tests
branch
from
84f3f9a to
b876b8d
Compare
|
Just pushed 1) changes to |
|
Hey @ezheidtmann... i made some comments over in your other #46. The latest release has evolved this library and taken into consideration many of the points you made over these PR conversations, so thank you. Closing this PR but would welcome new work on top of |
Not ready to merge! Need guidance on the following details:
setup.py?requests_mock?Tests can be run with
python -m unittest discover mds.tests, from the repo root.This PR adds the following:
tripsandstatus_changesendpoints with fixed object lists, with partial support for filters and paginationrequests_mockand a flask appProviderClient