Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lean Client for Single Provider #50

Closed
wants to merge 18 commits into from

Conversation

johnclary
Copy link

@johnclary johnclary commented Nov 28, 2018

This PR refactors api as a standalone package. It deviates from the original client in that it:

  • interfaces with only single provider
  • drops the internal auth.py and provider.py dependencies in favor of url, auth_type, token, and headers args.
  • does not interact with the provider registry at all or attempt OAuth

I don't expect this to be merged, but hopefully it contributes to the conversation around #35

@thekaveman
Copy link
Contributor

@johnclary I'm not sure if you meant to submit this as a pull request, but I won't be able to accept this since it deletes the other parts of the library we are currently using in production.

I'm happy to discuss refactoring the ProviderClient or api module more to help your use-cases. You may also want to check out the work/ideas presented by @ezheidtmann in #46, which is similarly trying to improve the ProviderClient.

@thekaveman thekaveman closed this Nov 30, 2018
@johnclary
Copy link
Author

@thekaveman i understand.

I don't expect this to be merged, but hopefully it contributes to the conversation around #35

Will look for activity on related issues and help where I can.

@thekaveman
Copy link
Contributor

Definitely helps the conversation, thanks!

@thekaveman
Copy link
Contributor

And apologies, I was too hasty in reading through your initial description and the code changes that I missed the line about this being more an exploration of an idea.

@johnclary johnclary deleted the single-provider branch December 7, 2018 05:04
@johnclary johnclary restored the single-provider branch December 7, 2018 05:04
@johnclary johnclary deleted the single-provider branch December 8, 2018 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants