Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to the Plugin Update Manager file #211

Open
bahiirwa opened this issue Feb 4, 2020 · 8 comments · May be fixed by #347
Open

Update to the Plugin Update Manager file #211

bahiirwa opened this issue Feb 4, 2020 · 8 comments · May be fixed by #347
Labels
enhancement New feature or request Has PR Issue has a PR.
Milestone

Comments

@bahiirwa
Copy link
Collaborator

bahiirwa commented Feb 4, 2020

The current update manager client file needs an update since the new release.

This looks like a partial update to the Update Manager code. I'm not sure this change is correct anyway but that would be an issue to take up with https://github.com/codepotent/Update-Manager.

Since this is not related to the purpose of this PR it should be removed from here and written up separately.

Originally posted by @nylen in https://github.com/_render_node/MDIzOlB1bGxSZXF1ZXN0UmV2aWV3VGhyZWFkMjMxMDEwODY2OnYy/pull_request_review_threads/discussion

@bahiirwa bahiirwa changed the title Update to the Update Manager code for Translation strings. Update to the Plugin Update Manager file Feb 6, 2020
@xxsimoxx
Copy link
Member

Version 2 is out now and an update will improve performances.
I can do a PR if you want, but i need 2 answer before:

  1. Now UpdateClient.class.php has removed text domains. More info here: Text domain in update client breaks core translation xxsimoxx/codepotent-update-manager#44. As those are core strings, it's up to CP to translate them, but if you want i can add CC text-domain.
  2. Images in CC are in assets/images and this is fixed hardcoded in the class. There are two filters now to do that. I can modify the class or use the filters, but in the latter case please let me know which is the preferred location to add those filters.

@bahiirwa
Copy link
Collaborator Author

About

  1. I think we need to ignore this for now. With version 2 of the CP repo, we shall have plugins update straight out of the box. It means this file will be removed. It’s a temporary measure and we don’t need to translate it as part of the core plugin.

Thoughts welcome.

@timbocode
Copy link
Contributor

I'm not sure I want to be introducing any significant changes just as we're ready to release beta1 of CC so for beta1 at least, I'd say it's business as usual.

@ghost
Copy link

ghost commented Sep 24, 2021

There is a new version of the Update manager client file that adds an extra line for security to lock the download location.

I'm not sure what happened with this issue, but do we want to look at updating the client file in the next release?

@ghost ghost added the enhancement New feature or request label Sep 24, 2021
@xxsimoxx
Copy link
Member

I can update the client and make the necessary to make it fully works.
Now it points to https://officialplugins.classicpress.net/ that seems not to be active.
Am I wrong?

@ghost
Copy link

ghost commented Sep 27, 2021

The update server should be:
const UPDATE_SERVER = 'https://classiccommerce.cc/';

Is that what you were asking?

@ghost
Copy link

ghost commented Sep 27, 2021

Also for anyone updating this, note that the client file has been renamed to: class-wc-update-client.php

and the path to the images needs to be:

// Set path and URL to this plugin's own images directory.
$image_path = untrailingslashit(WP_PLUGIN_DIR).'/'.$plugin.'/assets/images';
$image_url  = untrailingslashit(WP_PLUGIN_URL).'/'.$plugin.'/assets/images';

@xxsimoxx
Copy link
Member

and the path to the images needs to be

I'm writing a PR to use filters to do this, and also to support usage statistics opt-out.
So when/if a new version of the client will be released the update will be easier.

@xxsimoxx xxsimoxx linked a pull request Sep 27, 2021 that will close this issue
3 tasks
@bahiirwa bahiirwa added the Has PR Issue has a PR. label Oct 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Has PR Issue has a PR.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants