Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/corrections first review #30

Merged
merged 8 commits into from
Nov 6, 2023

Conversation

ClaudiaRojasSoto
Copy link
Owner

This feature adds a validation on the reservation model to avoid the reservation of cars in the past and adds instructions to run the API project on the user side, and the way to run the Rspec test.

All the above changes follow the suggestions of our first reviewer. Please @PabloBona, review these changes and give me feedback to improve the App and merge to develop to ask for a second review.

Greetings,
@ClaudiaRojasSoto

Copy link
Collaborator

@PabloBona PabloBona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved ✔
Hi @ClaudiaRojasSoto ,

Great job, Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:

Congratulations! 🎉

@ClaudiaRojasSoto ClaudiaRojasSoto merged commit 309a088 into develop Nov 6, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants