Merge pull request #45 from Marketparts/44-empty-column-in-header

Add last column to header array when value is empty
Claviz · Apr 8, 2022 · eb7e4c5 · eb7e4c5
2 parents 7fc530b + e7bf115
commit eb7e4c5
Show file tree

Hide file tree

Showing 4 changed files with 40 additions and 5 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/src/index.ts b/src/index.ts
@@ -48,7 +48,7 @@ function getFilledHeader(arr: any[], header: any[]) {
         return header;
     }
     const filledHeader = [];
-    for (let i = 0; i < arr.length; i++) {
+    for (let i = 0; i < Math.max(arr.length, header.length); i++) {
         filledHeader.push(
             header[i] ? header[i] : `[${numbersToLetter(i + 1)}]`
         );

diff --git a/tests/__snapshots__/xlsx-stream.spec.ts.snap b/tests/__snapshots__/xlsx-stream.spec.ts.snap
@@ -1345,8 +1345,9 @@ Array [
       "column1",
       "column2",
       "column3",
+      "column4",
     ],
-    "processedSheetSize": 1246,
+    "processedSheetSize": 2343,
     "raw": Object {
       "arr": Array [
         "hello",
@@ -1358,7 +1359,41 @@ Array [
         "column3": 123.123,
       },
     },
-    "totalSheetSize": 1246,
+    "totalSheetSize": 2343,
+  },
+  Object {
+    "formatted": Object {
+      "arr": Array [
+        undefined,
+        "world",
+        undefined,
+        456,
+      ],
+      "obj": Object {
+        "column2": "world",
+        "column4": 456,
+      },
+    },
+    "header": Array [
+      "column1",
+      "column2",
+      "column3",
+      "column4",
+    ],
+    "processedSheetSize": 2343,
+    "raw": Object {
+      "arr": Array [
+        undefined,
+        "world",
+        undefined,
+        456,
+      ],
+      "obj": Object {
+        "column2": "world",
+        "column4": 456,
+      },
+    },
+    "totalSheetSize": 2343,
   },
 ]
 `;

diff --git a/tests/assets/with-header.xlsx b/tests/assets/with-header.xlsx