Merge pull request #32 from santiq/master

Fix error handling in getWorksheets

src/index.ts

@@ -377,6 +377,9 @@ export function getWorksheets(options: IWorksheetOptions) {
     return new Promise<IWorksheet[]>((resolve, reject) => {
         function processWorkbook() {
             zip.stream('xl/workbook.xml', (err: any, stream: ReadStream) => {
+                if (err) {
+                    reject(err);
+                }
                 stream.pipe(saxStream({
                     strict: true,
                     tag: ['x:sheet', 'sheet'],
@@ -390,6 +393,7 @@ export function getWorksheets(options: IWorksheetOptions) {
                     zip.close();
                     resolve(sheets);
                 });
+                stream.on('error', reject);
             });
         }
 
@@ -401,6 +405,7 @@ export function getWorksheets(options: IWorksheetOptions) {
         zip.on('ready', () => {
             processWorkbook();
         });
+        zip.on('error', reject);
     });
 }
 

tests/assets/corrupted-file.xlsx

@@ -0,0 +1,3 @@
+invalid-content, corrupted-file, column 3
+0,1,3
+1,2,3

tests/xlsx-stream.spec.ts

@@ -95,6 +95,12 @@ it('gets worksheets with correct hidden info', async (done) => {
     done();
 });
 
+it('get worksheets should fail gracefully for a corrupted xlsx', () => {
+    return getWorksheets({
+        filePath: './tests/assets/corrupted-file.xlsx',
+    }).catch(e => expect(e).toMatch('Bad archive'));
+});
+
 it('gets worksheet by name, even if they are reordered', async (done) => {
     const data: any = [];
     const stream = await getXlsxStream({