-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature#25: As a user I want to deposit money: deposit endpoint and deposit transaction handling #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClementGib
changed the title
feature#25: Deposit endpoint and Transaction validator in progress
feature#25: As a user I want to deposit money: deposit endpoint and deposit transaction handling
Feb 20, 2024
ClementGib
commented
Feb 20, 2024
domain/src/main/java/com/cdx/bas/domain/transaction/Transaction.java
Outdated
Show resolved
Hide resolved
ClementGib
force-pushed
the
feature#25
branch
from
February 20, 2024 20:53
e4fdd49
to
75c3425
Compare
ClementGib
force-pushed
the
feature#25
branch
from
February 20, 2024 23:52
75c3425
to
783be73
Compare
ClementGib
commented
Feb 22, 2024
ClementGib
commented
Feb 22, 2024
ClementGib
force-pushed
the
feature#25
branch
2 times, most recently
from
February 23, 2024 20:00
6b72829
to
92500cf
Compare
…sabilities of services
ClementGib
force-pushed
the
feature#25
branch
from
February 24, 2024 20:49
92500cf
to
31ca199
Compare
ClementGib
commented
Feb 24, 2024
application/src/test/java/com/cdx/bas/application/bank/transaction/TransactionMapperTest.java
Outdated
Show resolved
Hide resolved
ClementGib
commented
Feb 24, 2024
application/src/test/java/com/cdx/bas/application/bank/transaction/TransactionMapperTest.java
Outdated
Show resolved
Hide resolved
application/src/test/java/com/cdx/bas/application/bank/transaction/TransactionTestUtils.java
Outdated
Show resolved
Hide resolved
application/src/test/java/com/cdx/bas/application/bank/transaction/TransactionTestUtils.java
Show resolved
Hide resolved
ClementGib
force-pushed
the
feature#25
branch
2 times, most recently
from
February 25, 2024 21:21
985fee6
to
8ac73db
Compare
Unit test of BankAccountResource missing an clean before merge. ✔️ |
ClementGib
force-pushed
the
feature#25
branch
5 times, most recently
from
March 2, 2024 16:33
75ad6bd
to
72d06dd
Compare
Fix Instant mock after removed timestamp to newTransaction in create transaction endpoint |
ClementGib
commented
Mar 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DONE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.