Bug fixs #2
Open
Bug fixs #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/quack review |
|
Oops, that one is on us 🙃 We'll investigate shortly! |
|
/quack review |
ghost
reviewed
Jun 15, 2023
There was a problem hiding this comment.
Thanks for the PR 🙏
Other sections
generate_sky_masks.py:L106main_pipeline_no_lidar.py:L77For a better experience, it's recommended to check the review comments in the tab Files Changed.
Feedback is a gift! Quack will adjust your review style when you add reactions to a review comment
| @@ -105,3 +103,4 @@ def process_folder(folder_to_process, colmap_img_root, mask_path, pic_ext, verbo | |||
| file_exts = ['jpg', 'JPG'] | |||
|
|
|||
| process_folder(args.img_dir, args.colmap_img_root, args.mask_root, file_exts, True, args.batchsize) | |||
|
|
|||
There was a problem hiding this comment.
The EOF should be a single blank line
Pattern explanation 👈
Adding a blank line as End of File (EOF) is a convention for file processing to mark the end of a character sequence. For more details, feel free to check this resource.Suggestion
Perhaps we could handle this like so:
Suggested change
Quack feedback loop 👍👎
This comment is about [invalid-eof]. Add the following reactions on this comment to let us know if:- 👍 that comment was on point
- 👀 that doesn't seem right
- 👎 this isn't important for you right now
- 😕 that explanation wasn't clear
| @@ -74,6 +74,7 @@ def main(): | |||
| if i not in args.skip_step: | |||
| print_step(i, "First thorough photogrammetry") | |||
| env["thorough_recon"].makedirs_p() | |||
| print(env["video_frame_list_thorough"]) | |||
There was a problem hiding this comment.
Let's avoid print calls in production-ready code
Pattern explanation 👈
print calls can be useful for developping and debugging. But moving to a production-ready system, users can select the logging level they want to display but prints don't offer that flexibility. For more details, feel free to check this resource.Code example
Here is an example of how this is typically handled:
# print("The payload is empty!")
import logging
logging.warning("The payload is empty!")Quack feedback loop 👍👎
This comment is about [print-statement]. Add the following reactions on this comment to let us know if:- 👍 that comment was on point
- 👀 that doesn't seem right
- 👎 this isn't important for you right now
- 😕 that explanation wasn't clear
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.