Update to Go 1.16 and fix broken go.mod mod declaration #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Plus `go mod tidy`
These type checks were not doing anything - which was surfaced by a `go vet` run on the more recent Go version. errors.As with the second argument of type *error will always return true. I played a little bit with trying to get a working typecheck in this test, but it didn't really work because of issues with the fork github.com/Clever/syslogparser. Since that parser didn't update self-references to point to itself instead of the upstream, our errors returned by this are already not really working correctly - sometimes they are Clever/syslogparser.ParseError and sometimes jeromer/syslogparser.ParseError. Fixing the underlying problem is out of scope for right now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.