Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/retry counter #14

Merged
merged 12 commits into from
Sep 24, 2019
Merged

Conversation

trottier
Copy link
Contributor

This feature counts how many times the particular game has been tried. This helps with analysis, and within the code helps in making decisions about what to do if a player appears to be "stuck"

@trottier trottier requested a review from JelmerT September 24, 2019 17:26
@trottier
Copy link
Contributor Author

We'll want to squash these ... only the last commit matters.

@JelmerT
Copy link
Member

JelmerT commented Sep 24, 2019

We could just use retrySequence for this instead of adding another var, just change it from a bool to int and change retrySequence = true; to retrySequence++;

you can then also rename the var if preferred

@trottier
Copy link
Contributor Author

Yeah I tried that initially, but it ended up creating a contingency that led to a slight logic change. Basically, the way it handles marking the first interaction as a retry, or not.

@trottier trottier merged commit bf4a64b into CleverPet:master Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants