Dev/rename to symon #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trottier
force-pushed
the
dev/rename-to-symon
branch
2 times, most recently
from
01821f9 to
aa2338e
Compare
|
Something weird happened somewhere, best to rebase your commits on top of the current master. Some file names were renamed back to 016 instead of 017, and some changes in the current master were reverted. |
JelmerT
requested changes
Oct 4, 2019
games/017_Symon/project.properties
Outdated
| @@ -0,0 +1,2 @@ | |||
| name=Symon | |||
There was a problem hiding this comment.
Suggested change
| name=Symon | |
| name=symon |
needs to match the filename
games.json
Outdated
| @@ -148,25 +148,17 @@ | |||
| "author": "CleverPet <[email protected]>", | |||
| "description_sentence":"Once your dog or cat can see the lights easily, this is a more \"active\" game for the Hub that challenges your dog or cat's \"paw-eye\" coordination", | |||
| "description_paragraph":"", | |||
| "type": "github.com", | |||
There was a problem hiding this comment.
Suggested change
| "type": "github.com", |
This shouldnt be here
JelmerT
force-pushed
the
dev/rename-to-symon
branch
from
61d80eb to
064b230
Compare
JelmerT
approved these changes
Oct 4, 2019
|
Rebased, fixed all the issues and added a standard readme for the Symon game. 👍 |
|
Yes, I've fixed my current master so this won't happen again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Performed rename of Simon to Symon.