Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The weather is broken (especially winter) #74886

Open
vetall812 opened this issue Jul 3, 2024 · 5 comments
Open

The weather is broken (especially winter) #74886

vetall812 opened this issue Jul 3, 2024 · 5 comments
Labels
(S1 - Need confirmation) Report waiting on confirmation of reproducibility

Comments

@vetall812
Copy link
Contributor

vetall812 commented Jul 3, 2024

Describe the bug

Some of weather condition are never appear on the overmap:

  • flurries
  • snow storm

Other weather condition appear when they aren't possible:

  • drizzle with temperature below 0C

Attach save file

N/A
you can recreate it easily

Steps to reproduce

  1. Spawn yourself a pair of binoculars
  2. Debug mutate night vision
  3. Skim through the whole year day by day and watch the sky

Expected behavior

No liquid precipitation when temperature below 0C:

  • Snow storm instead of rain storm in winter
  • Flurries instead of light drizzle
  • Snowing instead of drizzle/rain

Screenshots

In the middle of the winter (45 day of winter) and midnight temperature is -20C
But it is... drizzle?
image
image

Versions and configuration

  • OS: Windows
    • OS Version: 10.0.19045.4529 (22H2)
  • Game Version: cdda-experimental-2024-06-28-1704 d18e0a0 [64-bit]
  • Graphics Version: Tiles
  • Game Language: System language []
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food],
    Portal Storms Ignore NPCs [personal_portal_storms],
    Slowdown Fungal Growth [no_fungal_growth]
    ]

Additional context

No response

@vetall812 vetall812 added the (S1 - Need confirmation) Report waiting on confirmation of reproducibility label Jul 3, 2024
@ZhilkinSerg
Copy link
Contributor

There is just no temperature condition for a drizzle - https://github.com/CleverRaven/Cataclysm-DDA/blob/master/data/json/weather_type.json

@ZhilkinSerg
Copy link
Contributor

Required weather for flurries is flurries itself, which sounds wrong.

@ZhilkinSerg
Copy link
Contributor

Required weathers for snowstorm are thunder and lightning, which also sounds odd.

@vetall812
Copy link
Contributor Author

@Ramza13 , could you please take a look?

@Void-Seeker
Copy link
Contributor

Drizzle can kinda happen with the surface temperature slightly below zero, which result in ice crust accumulating on all surfaces. That doesn't happen when temperature is -14 °C, of course.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(S1 - Need confirmation) Report waiting on confirmation of reproducibility
Projects
None yet
Development

No branches or pull requests

3 participants