Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some ImGUI prompts have small size which resets to normal size after mouse move #77487

Closed
AdamBrezik opened this issue Oct 31, 2024 · 11 comments · Fixed by #77876
Closed

Some ImGUI prompts have small size which resets to normal size after mouse move #77487

AdamBrezik opened this issue Oct 31, 2024 · 11 comments · Fixed by #77876
Labels
[C++] Changes (can be) made in C++. Previously named `Code` ImGui Anything related to the new ImGui UI for SDL/tiles or ImTui for curses builds Info / User Interface Game - player communication, menus, etc. (S2 - Confirmed) Bug that's been confirmed to exist

Comments

@AdamBrezik
Copy link

Describe the bug

Some ImGUI prompts like examine or smash open as very small in size (or invisible) and reset to normal size after mouse move (tested with mouse show and hideKB settings).

Attach save file

Not connected to a save file. Previously only happened to me with a custom font (consolas bold), now it happens with the default, too.

Steps to reproduce

  1. Press s to smash or e to examine.
  2. See there's no prompt.
  3. Move the mouse.

Expected behavior

The prompt is shown normally from the beginning.

Screenshots

image
image

Versions and configuration

OS: Windows 10 Pro 64-bit 22H2 19045.5011
Game Version: 47225ca (tiles)
Ingame Language: Английский

Additional context

No response

@AdamBrezik AdamBrezik added the (S1 - Need confirmation) Report waiting on confirmation of reproducibility label Oct 31, 2024
@IdleSol
Copy link
Contributor

IdleSol commented Nov 1, 2024

Confirmed. cdda-windows-tiles-x64-2024-11-01-0729

@NetSysFire
Copy link
Member

I am pretty sure this is a direct consequence of #77297 - as such this is a duplicate.

@NetSysFire NetSysFire closed this as not planned Won't fix, can't repro, duplicate, stale Nov 1, 2024
@NetSysFire NetSysFire added (S3 - Duplicate) Bug that is duplicate of another one and removed (S1 - Need confirmation) Report waiting on confirmation of reproducibility labels Nov 1, 2024
@AdamBrezik
Copy link
Author

The effect seems to be the same, but I'm not experiencing this on item info window.

@AdamBrezik
Copy link
Author

From what I can understand, #77297 is fixed. My issue still exists. Perhaps it is directly connected to custom fonts as mentioned? Should it be a request instead?

@Night-Pryanik Night-Pryanik reopened this Nov 13, 2024
@Night-Pryanik
Copy link
Contributor

I use the default fonts, and have the same issue.

@NetSysFire NetSysFire added Info / User Interface Game - player communication, menus, etc. (S2 - Confirmed) Bug that's been confirmed to exist [C++] Changes (can be) made in C++. Previously named `Code` ImGui Anything related to the new ImGui UI for SDL/tiles or ImTui for curses builds and removed (S3 - Duplicate) Bug that is duplicate of another one labels Nov 13, 2024
@db48x
Copy link
Contributor

db48x commented Nov 13, 2024

These are all query_popups. @katemonster33, you wrote that code. Do you know what’s going wrong here?

@katemonster33
Copy link
Contributor

@db48x with query_popup, what happens sometimes is that the popup is initialized with this pattern:

query_popup().title("title")

I'm probably getting the syntax wrong, I'm on my phone. Anyway, with this pattern, I observed at points that the popup would size itself based off no contents, then the title would be set, except the redraw wouldn't happen until input is sent. I swear we fixed this but I need to research a bit

@db48x
Copy link
Contributor

db48x commented Nov 15, 2024

Ah, I see. Yea, I had a similar problem with the uilists. I fixed it by adding a timeout to the input handler so that we would automatically refresh the window, allowing it to immediately use the cached size from last time around. I looked at the code and found some popups that don’t have a time out; adding one to these fixed them. But the one used by waiting or sleeping (or other activities that take time) already has a timeout, so I am not quite sure what is going on.

@db48x
Copy link
Contributor

db48x commented Nov 15, 2024

I discovered that do_turn is creating and leaking a popup every single time around the loop while you wait. Fixing that fixes that class of popup.

@IdleSol
Copy link
Contributor

IdleSol commented Nov 17, 2024

cdda-windows-with-graphics-x64-2024-11-17-0712
1

The screen before entering the game (i.e. after character creation, but before appearing in the world).

@NetSysFire
Copy link
Member

I can confirm this happening.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` ImGui Anything related to the new ImGui UI for SDL/tiles or ImTui for curses builds Info / User Interface Game - player communication, menus, etc. (S2 - Confirmed) Bug that's been confirmed to exist
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants