Feat/sdk 4214/Encryption v2 #719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- adds remaining code from encryption task
- removes internal class - removes init block which is not needed - handles passing encryption level in a better way
- adds more performance to the code
- based on approach 2 in TAN - omits partial failure cases - moves logic to migratedb/prefs for finding data type - saves new info in boolean flag - more info in TAN
…roach from the TAN
CTLalit
requested review from
piyush-kukadiya,
CTLalit,
vasct,
nzagorchev and
kushCT
vasct
reviewed
Dec 30, 2024
clevertap-core/src/main/java/com/clevertap/android/sdk/StorageHelper.java
Show resolved
Hide resolved
clevertap-core/src/main/java/com/clevertap/android/sdk/cryption/CryptHandler.kt
Outdated
Show resolved
Hide resolved
clevertap-core/src/main/java/com/clevertap/android/sdk/cryption/AESGCMCrypt.kt
Outdated
Show resolved
Hide resolved
clevertap-core/src/main/java/com/clevertap/android/sdk/cryption/CryptMigrator.kt
Outdated
Show resolved
Hide resolved
clevertap-core/src/main/java/com/clevertap/android/sdk/cryption/CryptMigrator.kt
Outdated
Show resolved
Hide resolved
clevertap-core/src/main/java/com/clevertap/android/sdk/cryption/CryptMigrator.kt
Outdated
Show resolved
Hide resolved
clevertap-core/src/main/java/com/clevertap/android/sdk/cryption/CryptMigrator.kt
Outdated
Show resolved
Hide resolved
clevertap-core/src/main/java/com/clevertap/android/sdk/cryption/CryptMigrator.kt
Outdated
Show resolved
Hide resolved
clevertap-core/src/main/java/com/clevertap/android/sdk/cryption/AESGCMCrypt.kt
Outdated
Show resolved
Hide resolved
…s but plaintext to AES_GCM fails
- adds remaining code from encryption task
- removes internal class - removes init block which is not needed - handles passing encryption level in a better way
- adds more performance to the code
- the factory is created at a core instance level itself. - this allows us to have less dependencies while writing tests. - creates chance for easier mocks
- makes sure all classes are internal - avoids access for clients.
Anush-Shand
commented
Jan 3, 2025
| val iv: ByteArray, | ||
| val encryptedBytes: ByteArray | ||
| ) { | ||
| override fun equals(other: Any?): Boolean { |
There was a problem hiding this comment.
Are these ever used?
| val iv: ByteArray, | ||
| val encryptedBytes: ByteArray | ||
| ) { | ||
| override fun equals(other: Any?): Boolean { |
There was a problem hiding this comment.
This is already auto generated by data class. Is there any difference?
- removes compilation errors in tests - there is still need to check correctness.
clevertap-core/src/main/java/com/clevertap/android/sdk/cryption/EncryptionLevel.kt
Show resolved
Hide resolved
…cause of && operations
- adds verify methods - adds assertions
…ld-encrypted data was still persisted
| val dataMigrationRepository = DataMigrationRepository( | ||
| context = context, | ||
| config = config, | ||
| dbAdapter = baseDatabaseManager.loadDBAdapter(context) |
There was a problem hiding this comment.
loadDBAdapter() heavy operation on main thread
- moves the shared prefs migration code to the repository layer
- moved repo and database adapter load out of main thread - removes method args which are not needed
- returns a failure object instead of throwing exception
- adds nullability due to test cases problem
CTLalit
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://wizrocket.atlassian.net/browse/SDK-4206
[TAN][SDK] Encryption Algorithm Upgrade in SDK [W.I.P]
Support for API 21 and 22 uses a key saved in the prefs. Higher form of security for these API levels is difficult to achieve because of limitations