Integrate ClimaComms logging updates #3532
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nefrathenrici
commented
Jan 22, 2025
| Logging.global_logger(logger) | ||
| end | ||
|
|
||
| if comms_ctx isa ClimaComms.SingletonCommsContext |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tests out the latest logging features from ClimaComms, especially CliMA/ClimaComms.jl#104.
This adds a new config option
log_to_file = truewhich will enable ClimaComms.FileLogger, a logger that outputs to stdout and saves logs to disk inoutput_active/output.log. As part of this, MPI simulations will have an additional folderoutput_active/logsstoring the logs from each MPI process.TODO: remove
silence_non_root_processes, since this is also handled by ClimaComms now.