Skip to content

Try RRTMGP branch. #3690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Try RRTMGP branch. #3690

wants to merge 6 commits into from

Conversation

sriharshakandala
Copy link
Member

Purpose

Try RRTMGP branch sk/refactor_fluxes_change_datalayout

To-do

Content


  • I have read and checked the items on the review checklist.

@sriharshakandala
Copy link
Member Author

I have added the missing parent_type_array method. I tested it locally and it works!

@sriharshakandala
Copy link
Member Author

This does not seem to work. PR CliMA/ClimaCore.jl#2233 adds methods needed for loading and unloading between simple arrays and datalayout backed arrays in transposed order.

@charleskawczynski
Copy link
Member

This does not seem to work. PR CliMA/ClimaCore.jl#2233 adds methods needed for loading and unloading between simple arrays and datalayout backed arrays in transposed order.

Please incorporate CliMA/ClimaCore.jl#2233 into this PR to continue moving forward with this, so that we can see the overall impact (we've not yet accounted for adding a bunch of transpose copyto kernels).

@sriharshakandala
Copy link
Member Author

Replaced by #3715

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants