Enthalpy perturbation in hyperdiffusion tendency #3844
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akshaysridhar
force-pushed
the
as/hypdiff-ref
branch
4 times, most recently
from
dd31e4d to
1afd370
Compare
szy21
reviewed
Jun 16, 2025
src/cache/cache.jl
Outdated
| # Reference State | ||
| temp_profile = TD.TemperatureProfiles.DecayingTemperatureProfile{FT}( | ||
| thermo_params, | ||
| FT(299), # surface temperature |
There was a problem hiding this comment.
just curious - why not using 300?
There was a problem hiding this comment.
ARM, Gate, Rico use 299 or 299.8 in their surface setups ./src/surface_conditions/surface_setups.jl so I started with 299 as some representative ref-state. 300K is also fine.
trontrytel
approved these changes
Jun 25, 2025
akshaysridhar
force-pushed
the
as/hypdiff-ref
branch
from
ca9aba8 to
d4d61aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a moist reference state from which a reference enthalpy profile is computed - hyperdiffusion tendencies then use the perturbation of total enthalpy from this reference state.