Extend the ERA5 driven SCM to multi-day and smooth data #3863
+511
−163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Julians42
force-pushed
the
j/multi_smooth
branch
3 times, most recently
from
ba1ea82 to
da9befb
Compare
imreddyTeja
requested changes
Jun 23, 2025
| sim_forcing["hus"] = tvforcing["q"][lon_index, lat_index, :, :] | ||
| sim_forcing["ta"] = tvforcing["t"][lon_index, lat_index, :, :] | ||
| sim_forcing["zg"] = tvforcing["z"][lon_index, lat_index, :, :] | ||
| sim_forcing["ua"] = smooth_4D_era5(tvforcing, "u", lon_index, lat_index) |
There was a problem hiding this comment.
I think the assert statements on lines 250 and 251 need to be updated to reflect the extra requirements for 4d smoothing.
|
|
||
| defVar(ds, "ts", FT, ("x", "y", "z", "time")) | ||
| skt = | ||
| tv_inst["skt"][lon_index_surf2, lat_index_surf2, matching_time_indices] | ||
| skt = smooth_3D_era5(tv_inst, "skt", lon_index_surf2, lat_index_surf2) |
There was a problem hiding this comment.
same comment about updating the asserts
| lat_index_surf, | ||
| matching_time_indices, | ||
| ] / time_resolution | ||
| -smooth_3D_era5(tv_accum, "slhf", lon_index_surf, lat_index_surf) / |
There was a problem hiding this comment.
same comment about updating the asserts
| # get forcing file path | ||
| single_parsed_args = Dict( | ||
| "start_date" => Dates.format(dd, "yyyymmdd"), | ||
| "t_end" => "23hours", # some value between 0 and 24 hours to generate the single day file |
There was a problem hiding this comment.
I used get to return the start date as default so we don't need to pass t_end explicitly here. let me know if you thought of a better solution.
costachris
approved these changes
Jun 24, 2025
working multifile read; add functions for smoothing but not yet implemented updates smooth forcing
Julians42
force-pushed
the
j/multi_smooth
branch
from
08d9414 to
14a0781
Compare
Co-authored-by: Teja Reddy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two purposes:
Purpose
To-do
Content