Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix CCTR ClimaCore compat #1557

Merged
merged 1 commit into from
Nov 22, 2023
Merged

fix CCTR ClimaCore compat #1557

merged 1 commit into from
Nov 22, 2023

Conversation

juliasloan25
Copy link
Member

@juliasloan25 juliasloan25 commented Nov 22, 2023

In ClimaCoreTempestRemap v0.3.11, the compat entry for ClimaCore is "0.10.25, 0.11", but it's only compatible with >=0.11 because it uses Spaces.staggering.

We need to:

QA

  • Code follows the style guidelines OR N/A.
  • Unit tests are included OR N/A.
  • Code is exercised in an integration test OR N/A.
  • Documentation has been added/updated OR N/A.

@juliasloan25 juliasloan25 self-assigned this Nov 22, 2023
@Sbozzolo
Copy link
Member

I submitted this PR to fix the compat in the registry, so we don't need to bump the version of ClimaCoreTempestRemap.

(assuming that this is how you address these issues)

@juliasloan25
Copy link
Member Author

fixed by JuliaRegistries/General#95815

@Sbozzolo
Copy link
Member

We still need the correct compat in our Project.toml, so you can keep that (but remove the version bump)

@Sbozzolo Sbozzolo reopened this Nov 22, 2023
@Sbozzolo Sbozzolo changed the title fix CCTR ClimaCore compat, tag release fix CCTR ClimaCore compat Nov 22, 2023
@Sbozzolo Sbozzolo enabled auto-merge November 22, 2023 20:28
@Sbozzolo Sbozzolo merged commit c636de0 into main Nov 22, 2023
13 checks passed
@Sbozzolo Sbozzolo deleted the js/cctr-v0312 branch November 22, 2023 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants