Add DeviceSide #1561
Merged
Add DeviceSide #1561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@simonbyrne do you have any initial thoughts on this? |
Sbozzolo
force-pushed
the
gb/cuda_device
branch
from
23b8e79 to
0729f63
Compare
simonbyrne
reviewed
Nov 28, 2023
Sbozzolo
force-pushed
the
gb/cuda_device
branch
4 times, most recently
from
abe0a59 to
c37fa07
Compare
simonbyrne
reviewed
Nov 28, 2023
Sbozzolo
force-pushed
the
gb/cuda_device
branch
from
c37fa07 to
9f5a61a
Compare
simonbyrne
approved these changes
Nov 29, 2023
Sbozzolo
force-pushed
the
gb/cuda_device
branch
2 times, most recently
from
fdd5daf to
b6b84b7
Compare
|
@simonbyrne I added a commit to implement |
Sbozzolo
force-pushed
the
gb/cuda_device
branch
2 times, most recently
from
8285212 to
f749c97
Compare
Sbozzolo
force-pushed
the
gb/cuda_device
branch
from
f749c97 to
0924943
Compare
There are tests for distributed CUDA, but not for non-distributed CUDA
Sbozzolo
force-pushed
the
gb/cuda_device
branch
from
0924943 to
91047bf
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a new
Devicethat is used to identify structs that live on the GPU.DeviceSideDevice(and the associatedDeviceSideContext) are singleton that are passed throughAdapt.adapt_structureto those structs that are on the GPU.With this change, I also added support for
mapreduce_cudafor point spaces.