-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update compats and github workflows #1852
Conversation
1ac07e8
to
db92f6e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I support the compat/GHA related changes, but I'm a bit hesitant on the @static pkgversion(ClimaComms) >= v"0.6" &&
additions. I left a more detailed message about that. I'd prefer we remove them, but please have a look at the more detailed message.
Yes, I think we are over the update to 0.6, so I don't have problems with just bumping the compat. |
https://buildkite.com/clima/climacore-ci/builds/3953#01906f2f-ff58-4d80-80d1-7c4b5e2d4403
For I am thinking that the only possible explanation is that now we use a newer version of |
Yeah, let's just bump the limit and upgrade our dependencies. The type instability from |
Closes #1849, #1734, #1717, #1705, #1706