Fix adapt for vert topo and Topology2D #2187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charleskawczynski
force-pushed
the
ck/2186
branch
from
5ee41b7 to
124f35d
Compare
charleskawczynski
changed the title
charleskawczynski
force-pushed
the
ck/2186
branch
from
124f35d to
85eea25
Compare
|
While this PR closes #2186, there are still types that are not adapted correctly when converting between the cpu and gpu, and we should probably fix this. I've added broken tests in the mean time, and I'll open an issue. |
charleskawczynski
force-pushed
the
ck/2186
branch
from
85eea25 to
459035a
Compare
charleskawczynski
force-pushed
the
ck/2186
branch
from
459035a to
0154bb1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2186.