Tr/refactor fm internal index #2346
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a function to convert a FieldMatrix where each matrix entry has an eltype of some struct into a FieldMatrix where each entry has an eltype of a scalar. Add additional tests for scalar_matrixfields Use @test_all in tests Make suggested changes to tests and field_name_dict.jl Revert unrolled_findfirst Clean up field matrix tests and add support for DiagonalMatrixRows CamelCase struct name Clean up tests and get_scalar_keys wip backup Minimal working with allocs WIP1 WIP more allocs fix Assorted cleanup Fix dx/dx case reduce code duplication; fix example Add gpu test further cleanup, extend diagonalrow fix names test and comments Add docs docs bugfix remvoe bad refs fix docs formatting
imreddyTeja
commented
Jun 11, 2025
| @@ -61,7 +61,7 @@ coordinate_axis(::Type{<:LatLongPoint}) = (1, 2) | |||
|
|
|||
| coordinate_axis(coord::AbstractPoint) = coordinate_axis(typeof(coord)) | |||
|
|
|||
| @inline idxin(I::Tuple{Int}, i::Int) = 1 | |||
| @inline idxin(I::Tuple{Int}, i::Int) = I[1] == i ? 1 : nothing | |||
There was a problem hiding this comment.
I'm not sure if the original function is correct here because it behaves differently than the other idxin functions.
I found this when I was experimenting with using axis symbols to index with vs numbers.
pre-switch to type space should work fix broken tests bugfix fix implicit tensor rep tests WIPP1 working state Improve readability at cost of concise code update docs further cleanup
imreddyTeja
force-pushed
the
tr/refactor-fm-internal-index
branch
from
39ee021 to
14c7eed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
Update docs