Model setup of Energy Hydrology #1170
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Make model setup easier for soil models forced with atmospheric data. Our current constructor works well for simple cases, but when dealing with spatially varying parameters, and, eventually different parameterizations for albedo, etc, this helps expose that things that will change (the parameters, the parameterizations, the domain, the forcing), but hides that the things that will remain the same (how to setup the BC, create the model, sources, etc).
To-do
Better understand how to use this in simpler use cases. What about at a site where we know the soil type (clay) but not the parameters?
What about if we want to pass scalar parameters for all (that should work as is) - can demo in another case
add roughness parameters
Content