This repository has been archived by the owner on Mar 1, 2023. It is now read-only.
add in surface flow component; overland flow model #2174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmdeck
commented
Apr 8, 2021
kmdeck
commented
Apr 8, 2021
kmdeck
commented
Apr 8, 2021
kmdeck
commented
Apr 8, 2021
kmdeck
commented
Apr 8, 2021
kmdeck
commented
Apr 8, 2021
kmdeck
commented
Apr 8, 2021
kmdeck
commented
Apr 8, 2021
kmdeck
commented
Apr 8, 2021
|
bors try |
tryBuild failed: |
|
bors try |
tryBuild failed: |
|
@jakebolewski I think this looks pretty good except for the difference between the CSV file and the output, and I still am unsure if we should change the variable name to |
kmdeck
force-pushed
the
land/river
branch
2 times, most recently
from
b3c4884
to
fc08411
Compare
|
bors try |
tryBuild failed: |
|
bors try |
|
bors r+ |
|
👎 Rejected by too few approved reviews |
jakebolewski
approved these changes
Apr 20, 2021
|
bors r+ |
|
Merge conflict. |
wip model1 wip model1 wip bc wip driver wip river bc wip river bc added analytic function to test both no river and analytic case 1 run wip cleanup wip maxwell v catchment still wip maxwell tilted V added in wavespeed method for Rusanov flux changed names, documentation, added tilted V artifact, kept old River stuff soil tests seem to pass overland seems to work deleted old River.jl and test_no_river.jl files from remote fixed unit test removed old file, fixed doc formatter doesnt do the right thing move long running tilted v into its own test, run on cluster fix boundry condition test to match new interface gpu v catchment test fixes format minor doc stuff more minor doc stuff fixed precompute method changed variable name from area to height, removed width formatting fixed doc to reflect new name
|
bors r+ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add in a surface flow component to the Land Model. Currently, it supports a NoSurfaceFlow model, which is the default, and also overland flow by solving the shallow water equations under a number of assumptions (St Venant Equations).