Skip to content

feat: add P3 collision rates #577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: he/feat/p3-collisions-sub-parameterizations
Choose a base branch
from

Conversation

haakon-e
Copy link
Member

Purpose

P3 collision rates (moved from #543)

Implements source terms for the P3 scheme.

  • calculates the rate of collision between ice and liquid particles, numerically integrates over the size distributions, returns bulk source terms
  • computes dry and wet growth rates, partitioning sources into the ice and liquid phase

To-do

  • Add tests
  • check docs

Content

  • added function signatures
  • functions return bulk source terms

  • I have read and checked the items on the review checklist.

@haakon-e
Copy link
Member Author

haakon-e commented May 29, 2025

This change is part of the following stack:

Change managed by git-spice.

Copy link

codecov bot commented May 29, 2025

Codecov Report

Attention: Patch coverage is 66.19718% with 24 lines in your changes missing coverage. Please review.

Project coverage is 91.88%. Comparing base (f98ab2c) to head (8b0f1d1).

Additional details and impacted files
@@                               Coverage Diff                               @@
##           he/feat/p3-collisions-sub-parameterizations     #577      +/-   ##
===============================================================================
- Coverage                                        92.90%   91.88%   -1.02%     
===============================================================================
  Files                                               47       47              
  Lines                                             1789     1860      +71     
===============================================================================
+ Hits                                              1662     1709      +47     
- Misses                                             127      151      +24     
Components Coverage Δ
src 93.08% <66.19%> (-1.13%) ⬇️
ext 69.79% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@haakon-e haakon-e changed the base branch from he/rft/vterm-liq to he/rft/p3-integral-bounds May 29, 2025 20:44
@haakon-e haakon-e force-pushed the he/feat/p3-collisions branch from dfc527f to dc82464 Compare May 29, 2025 20:44
@haakon-e haakon-e force-pushed the he/rft/p3-integral-bounds branch from 368380c to 9a8e27d Compare May 29, 2025 20:47
@haakon-e haakon-e force-pushed the he/feat/p3-collisions branch from dc82464 to 050b3d0 Compare May 29, 2025 20:47
@haakon-e haakon-e force-pushed the he/rft/p3-integral-bounds branch from 9a8e27d to f787aad Compare May 29, 2025 20:48
@haakon-e haakon-e force-pushed the he/feat/p3-collisions branch from 050b3d0 to 02a0a5a Compare May 29, 2025 20:48
@haakon-e haakon-e force-pushed the he/rft/p3-integral-bounds branch from f787aad to 85f3e5e Compare May 29, 2025 20:50
@haakon-e haakon-e force-pushed the he/feat/p3-collisions branch from 02a0a5a to 25e5b77 Compare May 29, 2025 20:50
@haakon-e haakon-e force-pushed the he/rft/p3-integral-bounds branch from 85f3e5e to 558cb84 Compare May 29, 2025 21:27
@haakon-e haakon-e force-pushed the he/feat/p3-collisions branch from 25e5b77 to b2107a7 Compare May 29, 2025 21:27
@haakon-e haakon-e force-pushed the he/rft/p3-integral-bounds branch from 558cb84 to 5af0236 Compare May 31, 2025 00:11
@haakon-e haakon-e force-pushed the he/feat/p3-collisions branch from b2107a7 to 964ab51 Compare May 31, 2025 00:11
@haakon-e haakon-e force-pushed the he/rft/p3-integral-bounds branch from 5af0236 to c9ae84a Compare May 31, 2025 00:13
@haakon-e haakon-e force-pushed the he/feat/p3-collisions branch from 964ab51 to c9fad03 Compare May 31, 2025 00:13
@haakon-e haakon-e force-pushed the he/rft/p3-integral-bounds branch from c9ae84a to 5c98e9c Compare June 2, 2025 18:55
@haakon-e haakon-e force-pushed the he/feat/p3-collisions branch from c9fad03 to cf92e20 Compare June 2, 2025 18:56
@haakon-e haakon-e force-pushed the he/rft/p3-integral-bounds branch from 5c98e9c to 37e4ae2 Compare June 2, 2025 19:21
@haakon-e haakon-e force-pushed the he/feat/p3-collisions branch 2 times, most recently from 0ab021a to d86790e Compare June 2, 2025 22:07
@haakon-e haakon-e changed the base branch from he/rft/p3-integral-bounds to main June 3, 2025 23:39
@haakon-e haakon-e force-pushed the he/feat/p3-collisions-sub-parameterizations branch from 7265c76 to 2ee342c Compare June 21, 2025 02:24
@haakon-e haakon-e force-pushed the he/feat/p3-collisions branch from 8b1b15a to 09b8b28 Compare June 21, 2025 02:24
@haakon-e haakon-e force-pushed the he/feat/p3-collisions-sub-parameterizations branch from 2ee342c to 76460d6 Compare June 23, 2025 17:12
@haakon-e haakon-e force-pushed the he/feat/p3-collisions branch from 09b8b28 to d18df50 Compare June 23, 2025 17:12
@haakon-e haakon-e force-pushed the he/feat/p3-collisions-sub-parameterizations branch from 76460d6 to 52dac3d Compare June 23, 2025 18:07
@haakon-e haakon-e force-pushed the he/feat/p3-collisions branch 3 times, most recently from 5d97fbc to d84f832 Compare June 23, 2025 18:56
@haakon-e haakon-e force-pushed the he/feat/p3-collisions-sub-parameterizations branch from 52dac3d to 10438da Compare June 24, 2025 01:58
@haakon-e haakon-e force-pushed the he/feat/p3-collisions branch 5 times, most recently from 3717586 to d192d63 Compare June 24, 2025 02:04
@haakon-e haakon-e force-pushed the he/feat/p3-collisions-sub-parameterizations branch from 10438da to c176219 Compare June 24, 2025 23:08
@haakon-e haakon-e force-pushed the he/feat/p3-collisions branch from d192d63 to 225f10e Compare June 24, 2025 23:08
@haakon-e haakon-e force-pushed the he/feat/p3-collisions-sub-parameterizations branch from c176219 to b311d9e Compare June 24, 2025 23:55
@haakon-e haakon-e force-pushed the he/feat/p3-collisions branch from 225f10e to 03f5828 Compare June 24, 2025 23:56
@haakon-e haakon-e force-pushed the he/feat/p3-collisions-sub-parameterizations branch from b311d9e to e9cd940 Compare June 25, 2025 00:50
@haakon-e haakon-e force-pushed the he/feat/p3-collisions branch from 03f5828 to 4cb6850 Compare June 25, 2025 00:50
@haakon-e haakon-e force-pushed the he/feat/p3-collisions-sub-parameterizations branch from e9cd940 to 0cc1e86 Compare June 25, 2025 17:58
@haakon-e haakon-e force-pushed the he/feat/p3-collisions branch from 4cb6850 to d4ac2b3 Compare June 25, 2025 17:58
@haakon-e haakon-e force-pushed the he/feat/p3-collisions-sub-parameterizations branch from 0cc1e86 to f98ab2c Compare June 25, 2025 18:33
@haakon-e haakon-e force-pushed the he/feat/p3-collisions branch from d4ac2b3 to 8b0f1d1 Compare June 25, 2025 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant