CI with Julia v1.11

[navidcy]

This PR switches the CI to use Julia v1.11.
It also adds a Manifest with v1.11 ending so that there is still compatibility with previous versions.

Note the the distributed CI still does not have Julia v1.11 (right @Sbozzolo?) so there Julia v1.10 is used. This is possible because there are two Manifests.

[Sbozzolo]

Note the the distributed CI still does not have Julia v1.11 (right @Sbozzolo?) so there Julia v1.10 is used. This is possible because there are two Manifests.

I installed julia 1.11 on the Caltech cluster, but we haven't made a module yet (but it's coming today or so)

[glwagner]

This is possible because there are two Manifests.

There's only one manifest?

[ali-ramadhan]

This is possible because there are two Manifests.

There's only one manifest?

I assume he's referring to this new feature of Julia 1.11: https://julialang.org/blog/2024/10/julia-1.11-highlights/#manifest_versioning

[navidcy]

There's only one manifest?

The PR adds another Manifest specifically for v1.11 and keeps the older Manifest that works for v1.10. Or we can just have one Manifest (the one for v1.11) and drop the one for v1.10

[glwagner]

keeps the older Manifest that works for v1.10

The Manifest was deleted in #3783

[navidcy]

oh great! I missed that!
I wanted to delete it long now but I got resistance doing that before... Great! So I'll delete the new Manifest then as well!

[glwagner]

oh great! I missed that! I wanted to delete it long now but I got resistance doing that before... Great! So I'll delete the new Manifest then as well!

Deleting it seemed to help increase the likelihood that CI passed. Although, it did not fully solve the problem (and note a few other changes were also made on #3783).

[navidcy]

Noting that internal_tide.jl gives NaN with Julia v1.11 while all is OK with Julia v1.10; something with immersed boundaries....? I'm looking into it.

[simone-silvestri]

I think it's a plotting issue. We are filling up the immersed boundaries with NaN and, apparently, we cannot plot NaNs anymore? The error says:

ERROR: LoadError: On worker 2:
  | Looking up a non-finite or NaN value in a colormap is undefined.

[navidcy]

I ran the script and the actual simulation NaN-ed.

[glwagner]

I ran the script and the actual simulation NaN-ed.

That means Oceanangians isn't compatible with julia 1.11.

Do any other tests catch the issue? We can use this opportunity to add more tests.

[navidcy]

I’m trying to make an mwe

[ali-ramadhan]

Weird that this one example is behaving quite differently.

In Julia 1.10.6, the example produces flows that generally remain at a max CFL of ~0.13 or lower.

In Julia 1.11.1, the flow reaches a max CFL of ~0.2 after ~60 iterations and blows up within ~100 iterations.

Took a quick look but couldn't find anything obviously different.

Are there any tests that time step a hydrostatic model with an immersed boundary for 100+ time steps?

[glwagner]

Are there any tests that time step a hydrostatic model with an immersed boundary for 100+ time steps?

There are regression tests, but not sure if they are with immersed boundary or not.

[simone-silvestri]

Are there any tests that time step a hydrostatic model with an immersed boundary for 100+ time steps?

There are some tests but quite fragmented, not very exhaustive and that run only for 10 time steps, here for diffusion, here for advection and here for distributed vs serial.

There is scope to add more tests for the immersed boundary grid, especially for a partial cell bottom, which I believe is still not tested.
I can start adding some tests for it.

[glwagner]

Are there any tests that time step a hydrostatic model with an immersed boundary for 100+ time steps?

Good to add tests though I don't know why 100+ time steps matters specifically?

[navidcy]

Are there any tests that time step a hydrostatic model with an immersed boundary for 100+ time steps?

Good to add tests though I don't know why 100+ time steps matters specifically?

For a regression test, 10 should be plenty.