Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use on_architecture more liberally with boundary conditions #3893

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Use on_architecture more liberally with boundary conditions #3893

wants to merge 9 commits into from
+70 −25

Conversation

glwagner
Copy link
Member

@glwagner glwagner commented Nov 1, 2024

Addressing some of the issues on #3892, though we need tests.

@glwagner glwagner requested a review from navidcy November 1, 2024 04:57
@glwagner
Copy link
Member Author

glwagner commented Nov 1, 2024

ok this is ready

navidcy
navidcy approved these changes Nov 1, 2024
View reviewed changes
Copy link
Collaborator

@navidcy navidcy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@navidcy navidcy added the GPU 👾 Where Oceananigans gets its powers from label Nov 1, 2024
@navidcy
Copy link
Collaborator

navidcy commented Nov 1, 2024

@glwagner any idea about this:

https://buildkite.com/clima/oceananigans/builds/18542#0192e8c3-934a-4c74-b837-125fb8924484/31-1854

@glwagner
Copy link
Member Author

glwagner commented Nov 2, 2024

@glwagner any idea about this:

https://buildkite.com/clima/oceananigans/builds/18542#0192e8c3-934a-4c74-b837-125fb8924484/31-1854

Yes that was based on the wrong thinking that the flux of v is located at Center, Face, Center but it is actually located at Center, Face, Nothing (no vertical location)

@glwagner
Copy link
Member Author

glwagner commented Nov 4, 2024

Pretty sure the Enzyme errors are unrelated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@navidcy navidcy navidcy approved these changes

Assignees
No one assigned
Labels
GPU 👾 Where Oceananigans gets its powers from
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glwagner @navidcy