Run Enzyme tests on the GPU on Sverdrup #3911
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's the problem? Why disable the tests? |
|
It's running on the CPU so it is a duplicate of the Tartarus one, but it takes quite some time on Sverdrup because the CPU there is not that great. |
|
the fix is to change the test to GPU |
|
I'll do it |
|
Yeah I mentioned it in the PR |
simone-silvestri
changed the title
|
I changed the name of the PR then |
|
If they take too long to run / compile, we will have to come up with a differerent strategy |
|
How long do they take right now? |
|
It was taking upwards of an hour. But on the GPU I imagine it takes less. |
The distributed tests take 2h right? |
|
About an hour, but it depends if there is space on the cluster or not. |
|
Ok, so if it takes an hour we are alright I think |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #3910.
However, if it was just a typo and GPU support is in fact enabled, we can use this PR to pass the correct architecture to the grid and enable GPU tests
Let me know @jlk9 @wsmoses @glwagner