-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add warning for Julia version >= v1.11 #4109
Conversation
Not sure about this. If we allow the experimentation with julia 1.11 also from the user side, we can get bug reports more easily. I would probably just put a warning in the |
Unfortunately we don't have a great system for development / having a dev branch, so this hard restriction, while desirable for users, will make it hard to test as @simone-silvestri said. We could merge this, tag, and then immediately change it back on |
Let's put a warning in the |
A warning is nice. You can ask users to report issues. The weird thing is that it works on Mac as far as I know. What issue did @taimoorsohail find? |
Hi @glwagner! Still getting set up with ClimaOcean (so some errors may just be due to my learning the language and workflow) but with Julia 1.11.0 I get some circular dependency warnings when trying to run the
|
These errors on compilation are not necessarily a problem. The issue is that some simulations seem to blow up. That indicates there's a numerical difference which is concerning. |
For the record, doing this means that users on Julia v1.11 would simply get older versions of Oceananigans. If you really want to disallow Oceananigans on 1.11 entirely you should submit a PR to General to do that, but those PRs are usually questioned a bit. But support for v1.11 would be really helpful for GB |
Oh yeah, that makes sense. So it doesn't actually solve the problem. A warning would be better. And best would be to actually address the issue. |
Co-authored-by: Gregory L. Wagner <[email protected]>
Changed it from $ julia --project
_
_ _ _(_)_ | Documentation: https://docs.julialang.org
(_) | (_) (_) |
_ _ _| |_ __ _ | Type "?" for help, "]?" for Pkg help.
| | | | | | |/ _` | |
| | |_| | | | (_| | | Version 1.11.3 (2025-01-21)
_/ |\__'_|_|_|\__'_| | Official https://julialang.org/ release
|__/ |
julia> using Oceananigans
┌ Warning: You are using Julia v1.11 or later!"
│ Oceananigans is currently tested on Julia v1.10."
│ If you find issues with Julia v1.11 or later,"
│ please report at https://github.com/CliMA/Oceananigans.jl/issues/new
└ @ Oceananigans ~/.julia/packages/Oceananigans/2WYlH/src/Oceananigans.jl:118
[ Info: Oceananigans will use 12 threads |
until #3836 is resolved
cc @taimoorsohail