Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use SolutionTolerance instead of ResidualTolerance #139

Merged
merged 2 commits into from
Oct 5, 2022
Merged

Use SolutionTolerance instead of ResidualTolerance #139

merged 2 commits into from
Oct 5, 2022

Conversation

charleskawczynski
Copy link
Member

This PR replaces the RootSolvers.ResidualTolerance with RootSolvers.SolutionTolerance. Closes #135, #134, #130.

@codecov
Copy link

codecov bot commented Oct 4, 2022 •
edited
Loading

Codecov Report

Base: 93.10% // Head: 93.09% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (a671fd3) compared to base (e549ef2).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head a671fd3 differs from pull request most recent head 09bfc3f. Consider uploading reports for the commit 09bfc3f to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #139      +/-   ##
==========================================
- Coverage   93.10%   93.09%   -0.02%     
==========================================
  Files           9        9              
  Lines        1074     1071       -3     
==========================================
- Hits         1000      997       -3     
  Misses         74       74
Impacted Files Coverage Δ
src/relations.jl 96.13% <100.00%> (-0.02%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

tapios
tapios approved these changes Oct 5, 2022
View reviewed changes
Copy link
Contributor

@tapios tapios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@charleskawczynski
Copy link
Member Author

bors r+

@charleskawczynski
Copy link
Member Author

bors r-

@charleskawczynski
Copy link
Member Author

Actually, let's bump the version number too so that we can make a new release

@charleskawczynski
Copy link
Member Author

bors r+

bors bot added a commit that referenced this pull request Oct 5, 2022
@bors @charleskawczynski
Merge #139
45a4c01 
139: Use SolutionTolerance instead of ResidualTolerance r=charleskawczynski a=charleskawczynski

This PR replaces the `RootSolvers.ResidualTolerance` with `RootSolvers.SolutionTolerance`. Closes #135, #134, #130.

Co-authored-by: Charles Kawczynski <[email protected]>
@bors
Copy link
Contributor

bors bot commented Oct 5, 2022

Canceled.

@bors
Copy link
Contributor

bors bot commented Oct 5, 2022

Build succeeded:

@bors bors bot merged commit d7d03c0 into main Oct 5, 2022
@bors bors bot deleted the ck/tolerance_sol branch October 5, 2022 16:34
This was referenced Oct 6, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tapios tapios tapios approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Saturation adjustment enhancements
2 participants
@charleskawczynski @tapios