Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to #140.
Pros: the interface is likely more stable (assuming we'll continue with RootSolvers), since this gives us a lot of flexibility in specifying the tolerance.
Cons: users must depend on RootSolvers if they want to use custom tolerances
Similar to #140, in this PR we don't directly have the
temperature_tol
, and need some estimate for handling how we break out into freezing edge cases: