Add additional tests for queries with toLowCardinality and toNullable

ClibMouse · Apr 11, 2024 · 13774d8 · 13774d8
1 parent 70438f7
commit 13774d8
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/src/Analyzer/Passes/LogicalExpressionOptimizerPass.cpp b/src/Analyzer/Passes/LogicalExpressionOptimizerPass.cpp
@@ -627,7 +627,7 @@ class LogicalExpressionOptimizerVisitor : public InDepthQueryTreeVisitorWithCont
         if (!child_function || !isBooleanFunction(child_function->getFunctionName()))
             return;
 
-        if (function_node.getResultType()->isNullable() && !child_function->getResultType()->isNullable())
+        if (removeLowCardinality(constant->getResultType())->isNullable())
             need_rerun_resolve = true;
 
         if (maybe_invert)

diff --git a/tests/queries/0_stateless/03032_redundant_equals.reference b/tests/queries/0_stateless/03032_redundant_equals.reference
@@ -17,6 +17,10 @@
 100
 100
 101
+100
+101
+100
+101
 1
 1
 1

diff --git a/tests/queries/0_stateless/03032_redundant_equals.sql b/tests/queries/0_stateless/03032_redundant_equals.sql
@@ -26,7 +26,8 @@ SELECT * FROM test_table WHERE (NOT ((k in (101) = 0) OR (k in (100) = 1))) = 1;
 SELECT * FROM test_table WHERE ((k not in (101) = 0) OR (k in (100) = 1)) = 1;
 SELECT * FROM test_table WHERE ((k not in (99) = 1) AND (k in (100) = 1)) = 1;
 SELECT * FROM test_table WHERE ((k not in (101) = toNullable(0)) OR (k in (100) = toNullable(1))) = toNullable(1);
-
+SELECT * FROM test_table WHERE (((k NOT IN toLowCardinality(toNullable(101))) = toLowCardinality(toNullable(0))) OR ((k IN (toLowCardinality(100))) = toNullable(1)));
+SELECT * FROM test_table WHERE (((k IN toLowCardinality(toNullable(101))) = toLowCardinality(toNullable(0))) AND ((k NOT IN (toLowCardinality(100))) = toNullable(1))) = toNullable(toLowCardinality(0));
 
 SELECT count()
 FROM
Original file line number	Diff line number	Diff line change
Expand Up		@@ -17,6 +17,10 @@
		100
		100
		101
		100
		101
		100
		101
		1
		1
		1
Expand Down