Merge pull request #192 from ClibMouse/Kusto-p3-update-releasenote-range

Kusto p3 update releasenote range
ClibMouse · Jan 25, 2023 · 6531c15 · 6531c15
2 parents 49bdfcf + 0ec4ff8
commit 6531c15
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 11 deletions.
diff --git a/src/Parsers/Kusto/KQL_ReleaseNote.md b/src/Parsers/Kusto/KQL_ReleaseNote.md
@@ -3,6 +3,9 @@
 # January XX, 2023
 ## Functions
 - [range()](https://learn.microsoft.com/en-us/azure/data-explorer/kusto/query/rangefunction)  
+Difference from ADX:  
+   Return  empty array [] if range is empty, while ADX return NULL
+   The maxamum number of elements of array is 1000000 (limitation of clickhouse), 1,048,576  in ADX
 ```
 print '-- range function int, int, int --';
 print range(1, 10, 2);

diff --git a/src/Parsers/Kusto/KustoFunctions/KQLDynamicFunctions.cpp b/src/Parsers/Kusto/KustoFunctions/KQLDynamicFunctions.cpp
@@ -356,17 +356,6 @@ bool Zip::convertImpl(String & out, IParser::Pos & pos)
 
 bool Range::convertImpl(String & out, IParser::Pos & pos)
 {
-   // const auto fn_name = getKQLFunctionName(pos);
- //   if (fn_name.empty())
-   //     return false;
-
     return directMapping(out, pos, "kql_range");
-    //return directMapping(out, pos, "range");
-   /* auto start = getArgument(fn_name, pos);
-    auto end = getArgument(fn_name, pos);
-    const auto step = getOptionalArgument(fn_name, pos);
-
-    out = step ? std::format("kql_range({},{},{}))", start, end, step.value()) : std::format("kql_range({},{}))", start, end);*/
-   // return true;
 }
 }