Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

throw an exception if project-rename has duplicate columns #370

Open
wants to merge 530 commits into
base: Kusto-phase3
Choose a base branch
from
Open

throw an exception if project-rename has duplicate columns #370

wants to merge 530 commits into from

Conversation

bemitc
Copy link

@bemitc bemitc commented Jul 11, 2023

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

throw an exception if project-rename has duplicate columns

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

mcmajam and others added 30 commits April 3, 2023 07:27
@mcmajam @ltrk2
1913_take_any
2725b2a
@mcmajam @ltrk2
1913_take_any
219019b
@ltrk2
Add floor as an alias for bin
58a4d79
@SadiHassan @ltrk2
Case insensitive operators
b4a3ebd
@SadiHassan @ltrk2
fixed review comment issues
eae493f
@ltrk2
Update unit tests
3121a41
@ltrk2
Improve operators has, !has, has_all, has_any
0096d82
@ltrk2
Fix build errors
e0d587b
@ltrk2
Implement functional tests
9e14769
@ltrk2
Update unit tests
46c41ee
@SadiHassan @ltrk2
bug fix 1331
30af5f5
@SadiHassan @ltrk2
added arg check
8e7fb6e
@ltrk2
Update release notes
d2f6072
@kashwy @ltrk2
Kusto-phase3: add kql range() function
e057e27
@kashwy @ltrk2
Kusto-phase3: update release note for range() function
c66e961
@kashwy @ltrk2
Kusto-phase3: Add kql range operator
ff86c0c
@ltrk2
Add a missing include
10246ed
@larryluogit @ltrk2
Enable PR Sanity Checks (#197)
f0c9ef7 
Enable pr sanity checks
@SadiHassan @ltrk2
bug_fix_1332
5d1ceea
@SadiHassan @ltrk2
style fix -- whitespace
5b21c8b
@SadiHassan @ltrk2
fixed stylecheck --- typo
4024c23
@SadiHassan @ltrk2
fixed stylecheck --- style_output (part-1)
c8efe4a
@SadiHassan @ltrk2
fixed stylecheck --- style_output (part-2)
82913f7
@SadiHassan @ltrk2
fixed stylecheck --- style_output (part-3)
1543a1b
@SadiHassan @ltrk2
added more functional test + fix build error due to style correction
642178d
@SadiHassan @ltrk2
BuilderBinClangTidy error fix --- (part-1)
d525e94
@SadiHassan @ltrk2
BuilderBinClangTidy error fix --- (part-2)
c5d7348
@SadiHassan @ltrk2
BuilderBinClangTidy error fix --- (part-3)
35807de
@kashwy @ltrk2
Kusto-phase3: fix yaml style
72b308b
@kashwy @ltrk2
Kusto-phase3: trigger CI
d2e489e
SadiHassan and others added 19 commits April 5, 2023 21:15
@SadiHassan
isascii() function
9270730
@SadiHassan
using splitByString() instead of Regex
19ce72a
@SadiHassan
rebase and addressed review comments
0e38999
@mcmajam
Code reivew changes
270c418
@mcmajam
Merge pull request #281 from ClibMouse/KQL_epoch_fixes
b1f27ee 
Fix epoch related issue
@SadiHassan
Merge pull request #278 from ClibMouse/is_ascii_2335
4b13c94 
isascii() function
@SadiHassan
Merge pull request #282 from ClibMouse/bug_fix_2512
954b4aa 
bug_fix_2512
@SadiHassan
bug_fix_2511
765f1fc
@SadiHassan
addressed review comments
5e7da0f
@ltrk2
Implement a very toned-down version of hll functions
fcf3123
@SadiHassan
Merge pull request #285 from ClibMouse/bug_fix_2511
5100cbc 
bug_fix_2511
@ltrk2
Merge pull request #286 from ClibMouse/feature/kql-hll
313e27f 
Implement a very toned-down version of hll functions
@bemitc
add project-rename operator
7a4e97a
@bemitc
add unit and functional tests
d1b0094
@bemitc
add release notes
55f5ca1
@bemitc
syntax error if any of the expressions lack an assignment
1030317
@bemitc
improve parsing, exception if we rename the same column multiple time…
d24facc 
…s to match adx
@bemitc
move bracket_count outside loop
44ad4ae
@bemitc
throw an exception if project-rename has duplicate columns
11c74b8
@bemitc bemitc requested a review from kashwy July 11, 2023 13:49
ltrk2
ltrk2 suggested changes Jul 24, 2023
View reviewed changes
src/Parsers/Kusto/KQLContext.h Outdated Show resolved Hide resolved
src/Interpreters/executeQuery.cpp Outdated Show resolved Hide resolved
src/Parsers/Kusto/ParserKQLStatement.h
@@ -9,9 +9,14 @@ namespace DB

class ParserKQLStatement : public IParserBase
{
public:
explicit ParserKQLStatement() = default;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think there should be a default constructor, because otherwise you'd encounter cases where your solution wouldn't be able to function.

src/Parsers/Kusto/ParserKQLProjectRename.h Outdated Show resolved Hide resolved
src/Parsers/Kusto/ParserKQLProjectRename.h Outdated Show resolved Hide resolved
src/Parsers/Kusto/ParserKQLProjectRename.h Outdated Show resolved Hide resolved
src/Parsers/Kusto/ParserKQLProjectRename.h Outdated Show resolved Hide resolved
@ClibMouse ClibMouse deleted a comment from ltrk2 Jul 27, 2023
@kothiga kothiga force-pushed the Kusto-phase3 branch 2 times, most recently from 1e1f94f to 3fab19c Compare January 12, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ltrk2 ltrk2 ltrk2 requested changes

@kashwy kashwy Awaiting requested review from kashwy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bemitc @ltrk2 @mcmajam @SadiHassan @kashwy @larryluogit