New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: expose underlying string column for json #1037

Merged

ernado merged 1 commit into main from json_string_column

Feb 1, 2025

Member

SpencerTorres commented Feb 1, 2025

Summary

Small oversight from #1034, the underlying ColStr was not exported and could not be pre-allocated as needed.

proto.ColJSONStr {
	Str: proto.ColStr{
		Buf: make([]byte, 0, strSize * bufferSize),
		Pos: make([]proto.Position, 0, bufferSize),
	}
}

This PR exports Str so the above code is possible


          fix: expose underlying string column for json

607dc71

ernado merged commit 237fd55 into main

19 checks passed

ernado deleted the json_string_column branch

February 1, 2025 12:10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet