Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the styles of the Button Group #134

Merged
merged 15 commits into from
Sep 14, 2023
Merged

Updating the styles of the Button Group #134

merged 15 commits into from
Sep 14, 2023

Conversation

gjones
Copy link
Collaborator

@gjones gjones commented Sep 11, 2023

Summary

The button group needs to use the tokens for styling.

Before

CleanShot 2023-09-11 at 14 32 32@2x

After

CleanShot 2023-09-11 at 14 32 37@2x

@vercel
Copy link

vercel bot commented Sep 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
click-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 14, 2023 5:03pm

@gjones
Copy link
Collaborator Author

gjones commented Sep 11, 2023

@serdec There's a warning/error regarding the active prop.

Warning: Received `false` for a non-boolean attribute `active`.
If you want to write it to the DOM, pass a string instead: active="false" or active={value.toString()}

I'm not sure how you wanted to handle it so I've left it for now.

@gjones
Copy link
Collaborator Author

gjones commented Sep 11, 2023

Also this PR won't go green 🟢 until the token changes in #135 have been merged into main.

…-buttonGroup

# Conflicts:
#	src/styles/variables.classic.json
#	src/styles/variables.dark.json
#	src/styles/variables.json
#	src/styles/variables.light.json
@gjones gjones merged commit c4ad00c into main Sep 14, 2023
3 checks passed
@gjones gjones deleted the gj-buttonGroup branch September 14, 2023 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants