Add option to have a click event for the primary button #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
vineethasok
changed the title
serdec
reviewed
Sep 26, 2023
| @@ -13,6 +13,7 @@ export interface CardPrimaryProps { | |||
| infoUrl?: string; | |||
| infoText?: string; | |||
| size?: "sm" | "md"; | |||
| onButtonClick?: MouseEventHandler<HTMLElement>; | |||
There was a problem hiding this comment.
i think onButtonClick is a bit confusing and might make the user think it applies with a button inside the card? it's already possible to add a onClick event to the card, shouldn't we use the default porp?
There was a problem hiding this comment.
The onClick might be needed for the wrapper div thats why I added the onButtonClick
I discussed this yesterday with @gjones and we thought that there would be a case where we need the button to have a different function than the card
vineethasok
force-pushed
the
fix-card-click-function
branch
from
18e23bd to
b45a9cf
Compare
serdec
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no option to have onClick for the button
So adding a prop to allow onButtonClick and also pass props to the wrapper