add extra flexibility to panel #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
serdec
requested review from
vineethasok,
gjones and
fneves
and removed request for
vineethasok and
gjones
|
@gjones we can try with this flexible container. If this isn't enough i think we will have to spin it off to more specialized containers (form, sections, etc) |
vineethasok
requested changes
Sep 29, 2023
| width?: string; | ||
| fillWidth?: boolean; | ||
| height?: string; | ||
| fillHeight?: boolean; |
There was a problem hiding this comment.
I think we can directly add
fillHeight?: true
There was a problem hiding this comment.
no i think we want to keep the default behavior of a standard div since this panel will be used in lots of cases
There was a problem hiding this comment.
@serdec What I meant was about the typescript
In this case
or is allowed but is not allowed
Adding =false is visually not appealing and since the default is already undefined it won't match as true
vineethasok
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These Panel is the result of building the Settings page in the unified console. These are the properties needed to achieve the this design https://www.figma.com/file/sCKsQvoK8FlUXXfGyYtTaH/Data-Loading?type=design&node-id=678-17959&mode=design&t=4nuVLsZKrl8pjtpv-0